This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 16
feat!: update to acvm with non-homogeneous bb calls #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sirasistant
force-pushed
the
arv/bb_call_variants
branch
from
May 9, 2023 17:07
c4298b3
to
71ad590
Compare
sirasistant
force-pushed
the
arv/bb_call_variants
branch
from
May 11, 2023 08:44
f7f26b0
to
51457b4
Compare
sirasistant
changed the title
feat!: update to acvm with non-homogeneous bb calls DO NOT MERGE
feat!: update to acvm with non-homogeneous bb calls
May 11, 2023
TomAFrench
approved these changes
May 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one nit about a missing assertion.
Co-authored-by: Tom French <[email protected]>
TomAFrench
added a commit
that referenced
this pull request
May 12, 2023
* acvm-0.12.0: fix bad rebase chore: Release 0.1.2 (#183) fix: Remove star dependencies to allow publishing (#182) chore: Release 0.1.1 (#181) fix: Add description so crate can be published (#180) chore: update readme to new name and add contract note (#177) feat!: update to acvm with non-homogeneous bb calls (#169) update to latest changes chore: Release 0.1.0 (#173) use patch syntax chore: update to use new black box solver interface feat!: update to target acvm-84b5d18d chore(ci): Update tokens (#174) chore: Add release-please and publish workflows to project (#172) feat!: Update to ACVM v0.11.0 (#151) chore: remove usage of `std::mem::forget` (#164) chore: Enforce proper conversion of memory into fixed length array (#163) chore: Add test for Keccak256 constraint (#158) chore: use `WASMValue` for wasm arguments as well as return values (#157) feat!: Add Keccak constraints (#150)
TomAFrench
added a commit
that referenced
this pull request
May 19, 2023
* feat!: update to target acvm-84b5d18d * chore: update to use new black box solver interface * use patch syntax * update to latest changes * feat!: update to acvm with non-homogeneous bb calls (#169) * feat: update acvm * feat!: updated acvm to latest master * chore: update cargo toml * Update src/barretenberg_structures.rs Co-authored-by: Tom French <[email protected]> --------- Co-authored-by: Tom French <[email protected]> * fix bad rebase * feat!: Update backend to rely on WitnessMap (#152) Co-authored-by: Tom French <[email protected]> * update acvm * feat!: Implement CommonReferenceString trait (#139) * chore!: Remove filesystem access and utilize async fetch with range requests Co-authored-by: Tom French <[email protected]> * chore: Switch to tokio test macro for async function (#191) * chore: Remove `sled` & `tempfile` dev-dependencies (#190) * chore: Remove sled & tempfile dev-dependencies * chore: space out functions --------- Co-authored-by: Tom French <[email protected]> * chore: bump to crates.io release * Update src/crs.rs * chore: Remove streaming CRS download & indicator (#194) * Update src/acvm_interop/common_reference_string.rs * code review --------- Co-authored-by: Blaine Bublitz <[email protected]> Co-authored-by: Álvaro Rodríguez <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to noir-lang/acvm#269